[patch] Add skipPreCheck to launchUpgradePipeline#8
Merged
Conversation
JonahLuckett
requested review from
alequint,
andrercm,
durera,
leo-miran,
sanjayprab,
terenceq and
whitfiea
as code owners
durera
approved these changes
Jul 4, 2024
durera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding skipPreCheck to
launchUpgradePipelinearguments - keeping it false as a default which is the same default set in the cli and this way won't break anyone using the cli before the change proposed at ibm-mas/cli#1089The
pipelinerun-upgrade.yml.j2template already looks for the SkipPreCheck so no change needed therepython-devops/src/mas/devops/templates/pipelinerun-install.yml.j2
Line 26 in e946b05
For https://jsw.ibm.com/browse/MASCORE-3216
See slack thread at https://ibm-watson-iot.slack.com/archives/CNDB5GZ3P/p1720020453530109